-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmuxPlugins: expose mkDerivation for creating a TMUX plugins #44560
Conversation
babd6d6
to
a7726a7
Compare
I think an easier and better solution is to just expose that function in |
a7726a7
to
4553816
Compare
pkgs/misc/tmux-plugins/default.nix
Outdated
|
||
in rec { | ||
|
||
battery = buildTmuxPluginFrom2Nix { | ||
mkDerivation = a: (buildTmuxPlugin a); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly the same as mkDerivation = buildTmuxPlugin
because of currying. This means you can just declare mkDerivation
above directly, then inherit mkDerivation;
here. Or declaring mkDerivation
here would work as well (because it's in a rec
).
@infinisil it's done, PTAL. |
4553816
to
e8a5f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, but I'd like @pjan to have a look at this as well
Motivation for this change
Expose buildTmuxPlugin so users can use it in their overlays.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)